Re: [PATCH -next] proc/kcore: Make kcore_modules static

Mukesh Ojha <mojha@xxxxxxxxxxxxxx> · Thu, 21 Mar 2019 01:25:30 +0530

On 3/20/2019 7:24 PM, Yue Haibing wrote:
From: YueHaibing <yuehaibing@xxxxxxxxxx>

Fix sparse warning:

fs/proc/kcore.c:591:19: warning:
  symbol 'kcore_modules' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
---
  fs/proc/kcore.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index bbcc185..378f453 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
  /*
   * MODULES_VADDR has no intersection with VMALLOC_ADDR.
   */
-struct kcore_list kcore_modules;
+static struct kcore_list kcore_modules;
  static void __init add_modules_range(void)
  {
  	if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {


Acked-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>







