Re: WARNING: syz-executor still has locks held!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed 20-03-19 14:24:11, Oleg Nesterov wrote:
> On 03/20, Michal Hocko wrote:
> >
> > Yes we do hold the cgred mutex while calling freezable_schedule but why
> > are we getting a warning is not really clear to me. The task should be
> > hidden from the freezer so why do we warn at all?
> try_to_freeze() calls debug_check_no_locks_held() and this makes sense.

Yes it does. But it already ignores PF_NOFREEZE tasks and I fail to see
why is PF_FREEZER_SKIP any different. Yes we know we are holding the
lock and we have discussed that left and right before the patch was
merged but it seems that skipping the task was the only viable option
to fix suspend issues as removing the cgred is way way too complicated.

That being said, I was arguing against the patch initially because it
was a hack but sometimes that is the only way viable path short term.
Michal Hocko

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux