On Tue, Mar 19, 2019 at 12:35:26PM +1100, Tobin C. Harding wrote: > On Tue, Mar 19, 2019 at 10:14:33AM +1100, Tobin C. Harding wrote: > > Use code-block for C source code. With this in place we can rename the > > .txt file to .rst. This introduces a few warnings that will be fixed > > in proceeding patches. > > > > Add '.. code-block:: c' to C source code snippets. Rename the file to > > use rst file suffix. > > I just realised that a better way to document these structs is to do so > above the actual struct definition in the source file then include those > docs in the documentation file. Please either drop this set or only consider patches 1-8 for merge. I haven't worked out _exactly_ how to move the docs from Documentation/filesystems/vfs to the source code files but I've played with it enough now to feel it is possible and it is definitely better. Just have to massage Sphinx into agreeing with me. I thought the whole reason we have docstring comments is because we all agreed that docs close to code hove more chance of staying relevant. vfs.txt proves that nicely (docs in it from 2.6 for structs that are actively used and developed). Sorry for the noise, one day I'll work these things out _before_ sending the patches :) thanks, Tobin.
