On Mon, Mar 18, 2019 at 01:05:13PM +0200, Amir Goldstein wrote: > > > > > +For example, when an fanotify file descriptor is created using > > > > > +.B FAN_REPORT_FID > > > > > +the > > > > > +.I info_type > > > > > +field of this header is set to > > > > > +.BR FAN_EVENT_INFO_TYPE_FID . > > > > > +Event listeners can use this field to check that events of the correct > > > > > +type are being received. > > > > > > > > I think here you should also speak about the 'len' field in the header > > > > which can be used to skip additional information that is not understood / > > > > uninteresting for the receiver of the event. > > > > > > I don't have any objections to add this as I do believe mentioning it has > > > added benefit. Perhaps we could consider adding in a section which describes > > > all the fanotify_event_info_header fields? Maybe it's not necessary though, > > > and just mentioning these two fields here would be enough. Thoughts? > > > > Well, there are just two fields - 'info_type' and 'len'. There's also 'pad' > > but that doesn't really count ;). So I think that briefly explaining 'len' > > is all that's needed. If you want to formalize this a bit more in a > > separate section, I'm not opposed but I don't think it's really necessary. Jan, sure I'd have to agree with you, but was just thinking to put the thought out there. > I did not get a reply from Matthew, so to make sure my comment > about 'len' wasn't missed. Sorry Amir, I definitely did see the note you dropped about the 'len' field. Apologies for not getting back to you directly about that. > I think 'len' field should get a similar treatment to 'event_len' - > "In the current implementation, the value of len is always > (event_len - FAN_EVENT_METADATA_LEN). However, the API > is designed..." > > And the same sentence about 'event_len' field is now no longer > correct so it should be updated, e.g.: > > event_len > ... > Without FAN_REPORT_FID, the value of event_len is always > FAN_EVENT_METADATA_LEN. With FAN_REPORT_FID, > event_len also includes the variable length file identifier. Understood, I will make sure to incorporate these details into my revised patch. -- Matthew Bobrowski
