On Fri, Mar 15, 2019 at 9:27 AM Jens Axboe <axboe@xxxxxxxxx> wrote: > > Linus, curious on your opinion on this one. I had this as part of the > original series, but removed it from the pull request due to the > mincore etc discussions. I'd rather not have new ways to leak cache information, and in fact already the IOCB_NOWAIT is a bit questionable for that. But afaik, the non-O_DIRECT paths don't even support it to begin with for some filesystems. Wasn't the whole point of this io_ring that we'd move *away* from direct block access and O_DIRECT? I'm seeing a lot of stuff that looks like just "more of the same old O_DIRECT garbage" that seems to be all about thinking that IO doesn't cache. Haven't we gotten over that already? It was one of the arguments you used for io_ring to begin with. Linus