Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote: > > Move kernel_read_file() to fs/read_write.c and out of fs/exec.c as it's not > > actually used by anything in the execve subsystem. > > All files being opened by the kernel should be calling one of these > helper routines. Has that changed? prepare_binprm() uses kernel_read() and has done since at least 2014. The binfmt drivers also use kernel_read(). Since kernel_read_file() is used by a bunch of things that aren't exec, even if we switch exec to it, it should probably still go in fs/read_write.c since it seems generic. David