On Thu, 2019-02-21 at 17:46 -0500, Roman Gushchin wrote: > On Wed, Feb 20, 2019 at 06:27:07PM +1100, Dave Chinner wrote: > > On Wed, Feb 20, 2019 at 04:50:31PM +1100, Dave Chinner wrote: > > > I'm just going to fix the original regression in the shrinker > > > algorithm by restoring the gradual accumulation behaviour, and > > > this > > > whole series of problems can be put to bed. > > > > Something like this lightly smoke tested patch below. It may be > > slightly more agressive than the original code for really small > > freeable values (i.e. < 100) but otherwise should be roughly > > equivalent to historic accumulation behaviour. > > > > Cheers, > > > > Dave. > > -- > > Dave Chinner > > david@xxxxxxxxxxxxx > > > > mm: fix shrinker scan accumulation regression > > > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > JFYI: I'm testing this patch in our environment for fixing > the memcg memory leak. > > It will take a couple of days to get reliable results. Just to clarify, is this test with fls instead of ilog2, so the last item in a slab cache can get reclaimed as well? -- All Rights Reversed.
Attachment:
signature.asc
Description: This is a digitally signed message part