Jan Kara <jack@xxxxxxx> writes: > On Thu 21-02-19 19:11:14, Aneesh Kumar K.V wrote: >> On 2/21/19 5:42 PM, Jan Kara wrote: >> > Hi Aneesh, >> > >> > On Thu 21-02-19 12:52:39, Aneesh Kumar K.V wrote: > >> Do pfn_mkwrite callback need to insert the pfn details for a RO->RW fault >> type? Can't we skip that pfn insert and let finish_mkwrite_fault handle that >> pte update? > > Yes, pfn_mkwrite() must fully update the PTE as the PTE update must happen > under a lock that is private to DAX code. Using ptep_set_access_flags() > in iomap code isn't going to be simple either. I have to think whether / > how that is possible. Can we use ptep_clear_flush followed by set_pte_at()? -aneesh
