On Mon, Feb 11, 2019 at 01:57:08PM +0100, Christoph Hellwig wrote: > On Fri, Feb 08, 2019 at 09:43:52AM +0100, Christoph Hellwig wrote: > > Agreed. Please don't change the FIEMAP uapi. If we need to check > > for a request coming from bmap just defined an internal FIEMAP flag > > as the last available flag in the flags word, and reject it when > > it comes from userspace in fiemap. > > Based on the new thread you started it seems like this go lost. I think > we are 99% done with the bmap through fiemap series, and it is just > missing this internal flag to make progress. Let's finish this off > before starting another big project in the area. I'm more than happy in see your reply, I'd love to finish this, but I got stuck in how to make some filesystems deny a FIBMAP call once they do support FIEMAP but not FIBMAP. I have this patch almost ready to go anyway. Do you agree in keep this flag in fi_flags field? Or maybe some other place, dunno, maybe a new fi_private field. > -- Carlos
