We just fixed a bug in cifs.ko where it would incorrectly return success
for setfattr -x user.does-not-exist.
This patch adds a test case for this.
Xfstests already have tests for setfattr -x in generic/097
but we can not yet use that test for cifs since we can only support
the user namespace.
Signed-off-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>
---
tests/cifs/002 | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/cifs/002.out | 6 ++++++
tests/cifs/group | 1 +
3 files changed, 60 insertions(+)
create mode 100755 tests/cifs/002
create mode 100644 tests/cifs/002.out
diff --git a/tests/cifs/002 b/tests/cifs/002
new file mode 100755
index 00000000..80baa66a
--- /dev/null
+++ b/tests/cifs/002
@@ -0,0 +1,53 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2000-2004 Silicon Graphics, Inc. All Rights Reserved.
+# Copyright (c) 2017 Google, Inc. All Rights Reserved.
+#
+# FS QA Test No. 002. Modified from generic/097
+#
+# simple attr test for deleting a non-existing EA:
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+file=$TEST_DIR/foo
+
+_cleanup()
+{
+ rm -f $tmp.* $file
+}
+
+setfattr()
+{
+ echo $SETFATTR_PROG "$@" >>/tmp/foo
+ $SETFATTR_PROG "$@" |& _filter_test_dir
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/attr
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_test
+_require_attrs
+
+echo -e "\ncreate file foo"
+rm -f $file
+touch $file
+
+echo -e "\nunset EA <does-not-exist>:"
+setfattr -x user.does-not-exist $file
+
+# success, all done
+status=0
+exit
diff --git a/tests/cifs/002.out b/tests/cifs/002.out
new file mode 100644
index 00000000..163eb48a
--- /dev/null
+++ b/tests/cifs/002.out
@@ -0,0 +1,6 @@
+QA output created by 002
+
+create file foo
+
+unset EA <does-not-exist>:
+setfattr: TEST_DIR/foo: No such attribute
diff --git a/tests/cifs/group b/tests/cifs/group
index 6d07b1c4..191e6a67 100644
--- a/tests/cifs/group
+++ b/tests/cifs/group
@@ -4,3 +4,4 @@
# - comment line before each group is "new" description
#
001 auto quick
+002 auto quick
--
2.13.6
