On Thu, Jan 10, 2019 at 12:41:43PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > sb_init_dio_done_wq() is defined in fs/direct-io.c and declared in > fs/internal.h, but the declaration isn't included at the point of the > definition. Include the header to enforce that the definition matches > the declaration. > > This addresses a gcc warning when -Wmissing-prototypes is enabled. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > fs/direct-io.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index dbc1a1f080ceb..42e497e3a39a9 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -37,6 +37,7 @@ > #include <linux/uio.h> > #include <linux/atomic.h> > #include <linux/prefetch.h> > +#include "internal.h" > > /* > * How many user pages to map in one call to get_user_pages(). This determines > -- > 2.20.1.97.g81188d93c3-goog > Ping. Al, are you planning to apply this? - Eric