On Thu 10-01-19 19:04:40, Amir Goldstein wrote:
> @@ -111,6 +118,9 @@ static inline void fsnotify_move(struct inode *old_dir, struct inode *new_dir,
> new_dir_mask |= FS_ISDIR;
> }
>
> + if (d_is_dir(moved))
> + mask |= FS_ISDIR;
> +
> fsnotify(old_dir, old_dir_mask, source, FSNOTIFY_EVENT_INODE, old_name,
> fs_cookie);
> fsnotify(new_dir, new_dir_mask, source, FSNOTIFY_EVENT_INODE, new_name,
The 'isdir' argument of fsnotify_move() is exactly d_is_dir(moved). So I've
simplified the code by:
if (isdir) {
old_dir_mask |= FS_ISDIR;
new_dir_mask |= FS_ISDIR;
- }
-
- if (d_is_dir(moved))
mask |= FS_ISDIR;
+ }
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
