Yes, but I don't think they should be there. You put them into pvfs2_file_aio_read_iovec way back when (Martin guesses you were making sure that you had fully eradicated private's use) and I left them in when I changed that function over to pvfs2_file_read_iter. After that, they've just gone along for the ride... BUG_ONs that the maintainer can't justify might be the kind of thing that would make Linus violate the new code of conduct :-) ... -Mike On Wed, Feb 6, 2019 at 1:58 AM Christoph Hellwig <hch@xxxxxx> wrote: > > Didn't these catch the issue you fix in patch 2?
