On Tue, Feb 05, 2019 at 07:25:18PM +0100, Christoph Hellwig wrote: > On Tue, Feb 05, 2019 at 10:56:01AM +0100, Carlos Maiolino wrote: > > > Any reason this function isn't in inode.c next to the caller and marked > > > static? > > > > > > > No reason other than to keep it close to its peer fiemap_fill_user_extent(), I > > honestly do prefer to keep both together than in separated files. But, I'm up > > to move it to fs/inode.c if required. > > After your series fiemap_fill_user_extent should be static and close > to it's caller, so with the kernel one in inode.c everything should > be neat and symmetric. You are right, I didn't pay attention to that, thanks for the heads up, I'll fix it on the next version -- Carlos
