Looks good. Minor nitpick: > +static void omfs_put_super(struct super_block *sb) > +{ > + struct omfs_sb_info *sbi = OMFS_SB(sb); > + if (sbi) { This if check is no needed, as your fill_super method never returns success without setting it up. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html