On Mon, Jan 28, 2019 at 6:25 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > On Fri, Jan 25, 2019 at 5:27 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote: > > On 2019-01-25 16:45, Paul Moore wrote: > > > On Wed, Jan 23, 2019 at 1:35 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote: > > > > Don't fetch fcaps when umount2 is called to avoid a process hang while > > > > it waits for the missing resource to (possibly never) re-appear. > > > > > > > > Note the comment above user_path_mountpoint_at(): > > > > * A umount is a special case for path walking. We're not actually interested > > > > * in the inode in this situation, and ESTALE errors can be a problem. We > > > > * simply want track down the dentry and vfsmount attached at the mountpoint > > > > * and avoid revalidating the last component. > > > > > > > > This can happen on ceph, cifs, 9p, lustre, fuse (gluster) or NFS. > > > > > > > > Please see the github issue tracker > > > > https://github.com/linux-audit/audit-kernel/issues/100 > > > > > > > > Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx> > > > > --- > > > > fs/namei.c | 2 +- > > > > fs/namespace.c | 2 ++ > > > > include/linux/audit.h | 15 ++++++++++----- > > > > include/linux/namei.h | 3 +++ > > > > kernel/audit.c | 10 +++++++++- > > > > kernel/audit.h | 2 +- > > > > kernel/auditsc.c | 6 +++--- > > > > 7 files changed, 29 insertions(+), 11 deletions(-) ... > You posted this patch on the 23rd (last Wednesday), let's give the FS > folks another day or two to comment since it does touch their code. > If we don't see any objections by later this week I'll merge it into > audit/next. I'm not seeing any objections from the fs folks, so I'm merging this into audit/next. -- paul moore www.paul-moore.com
