On 1/28/19 11:27 PM, Christoph Hellwig wrote: > On Mon, Jan 28, 2019 at 09:46:17AM -0700, Jens Axboe wrote: >> I think that can go both ways. If we create it early, it'll just be a >> pointless helper. Don't really care too much about this particular case. > > Without the no-op locking fix we don't really need the current > __io_cqring_add_event anymore, so we'd still have two somewhat > reasonably defined helpers. Yeah, killed it, which also fixes your complaint about adding a new helper in the poll patch. -- Jens Axboe
