On Fri, Jan 25, 2019 at 04:27:47PM +0800, Geliang Tang wrote: > --- /dev/null > +++ b/fs/squashfs/acl.c > @@ -0,0 +1,69 @@ > +/* > + * Squashfs - a compressed read only filesystem for Linux No SPDX line? > + * > + * Copyright (c) 2018 > + * Phillip Lougher <phillip@xxxxxxxxxxxxxxx> Did Phillip write this file, or did you? > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2, > + * or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. No need for any of that header stuff, if you put in the proper SPDX line. > --- /dev/null > +++ b/fs/squashfs/acl.h > @@ -0,0 +1,31 @@ > +/* > + * Squashfs - a compressed read only filesystem for Linux <snip> Same comments here about this file. thanks, greg k-h