On Wed, Jan 23, 2019 at 12:48:03PM +0100, Jan Kara wrote: > On Mon 21-01-19 00:54:32, Phillip Potter wrote: > > Deduplicate the ocfs2 file type conversion implementation and remove > > OCFS2_FT_* definitions - file systems that use the same file types > > as defined by POSIX do not need to define their own versions and can > > use the common helper functions decared in fs_types.h and implemented > > in fs_types.c > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > > The patch looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Honza Thank you very much Jan. Regards, Phil