Hey everyone, Al gave me a really helpful review of binderfs and pointed out a range of bugs. The most obvious and serious ones have fortunately already been taken care of by patches sitting in Greg's char-misc-linus tree. The others are hopefully all covered in this patchset. /* Changelog */ Nothing major apart from working in a bunch of good comments and suggestions from Al. The most interesting one is probably the switch from d_alloc_name() + d_lookup() to lookup_one_len() when detecting name clashes between binder devices. This also forces us to switch from d_add() to d_instantiate() since lookup_one_len() adds new dentries to the hashqueue. If we were to use d_add() after this we'd end up with the same dentry over the same inode twice. I moved the switch from d_add() to d_instantiate() into a separate commit. The rest should hopefully be pretty mundane. Thanks! Christian Christian Brauner (7): binderfs: remove outdated comment binderfs: prevent renaming the control dentry binderfs: rework binderfs_fill_super() binderfs: rework binderfs_binder_device_create() binderfs: kill_litter_super() before cleanup binderfs: drop lock in binderfs_binder_ctl_create binderfs: switch from d_add() to d_instantiate() drivers/android/binderfs.c | 121 +++++++++++++------------------------ 1 file changed, 43 insertions(+), 78 deletions(-) -- 2.19.1
