Christoph Hellwig <hch@xxxxxx> wrote: > generic_fillattr is an optional helper that isn't used by all > file systems, move handling purely based on inode flags to > vfs_getattr_nosec, which is common code. > > This fixes setting this flag for file systems not using generic_fillattr > like xfs. The only problem I have with this change is that you've moved the flag setting to after the ->getattr() call, which means that the filesystem cannot override it. I'm not sure that particularly matters in the case of these two flags, but it might encourage similar things to be put there where it could matter. David
