On Tue 15-01-19 09:07:59, Jan Kara wrote: > Agreed. So with page lock it would actually look like: > > get_page_pin() > lock_page(page); > wait_for_stable_page(); > atomic_add(&page->_refcount, PAGE_PIN_BIAS); > unlock_page(page); > > And if we perform page_pinned() check under page lock, then if > page_pinned() returned false, we are sure page is not and will not be > pinned until we drop the page lock (and also until page writeback is > completed if needed). After some more though, why do we even need wait_for_stable_page() and lock_page() in get_page_pin()? During writepage page_mkclean() will write protect all page tables. So there can be no new writeable GUP pins until we unlock the page as all such GUPs will have to first go through fault and ->page_mkwrite() handler. And that will wait on page lock and do wait_for_stable_page() for us anyway. Am I just confused? That actually touches on another question I wanted to get opinions on. GUP can be for read and GUP can be for write (that is one of GUP flags). Filesystems with page cache generally have issues only with GUP for write as it can currently corrupt data, unexpectedly dirty page etc.. DAX & memory hotplug have issues with both (DAX cannot truncate page pinned in any way, memory hotplug will just loop in kernel until the page gets unpinned). So we probably want to track both types of GUP pins and page-cache based filesystems will take the hit even if they don't have to for read-pins? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
