On Tue, 8 Apr 2008 11:39:46 +0200 Jörn Engel <joern@xxxxxxxxx> wrote: > On Tue, 8 April 2008 02:24:17 +0200, Arnd Bergmann wrote: > > > > Great to see a new version finally posted again! > > As Artem already noted, the transition to write-back caching was a > significant change and initially caused a huge drop in quality. Took a > while. > > > On Tuesday 01 April 2008, joern@xxxxxxxxx wrote: > > > --- /dev/null 2008-04-02 16:29:12.813336657 +0200 > > > +++ linux-2.6.24logfs/fs/logfs/logfs_abi.h 2008-04-01 21:02:34.980239877 +0200 > > > @@ -0,0 +1,523 @@ > > > +/* > > > + * fs/logfs/logfs.h > > > > The comment doesn't match the file name, and the file name doesn't > > match the purpose -- you are not defining an "application" binary > > interface but rather the medium format, with the small exception > > of the chattr flags. > > Now it matches the file name. If you have a better name than "abi", > I'll use that. > > > > +#ifndef fs_logfs_logfs_abi_h > > > +#define fs_logfs_logfs_abi_h > > > > Everyone else uses capital letters for these. > > Changed. > Hm, logfs.patch.771 contains lowercase. Do you have your latest patch set somewhere online? Alternatively, would you mind pushing your git tree somewhere public? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
