On Mon, Jan 14, 2019 at 9:31 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > Hi Amir, > > url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/fanotify-add-support-for-more-event-types/20190111-090241 > > smatch warnings: > fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'type'. > fs/notify/fanotify/fanotify.c:194 fanotify_encode_fid() error: uninitialized symbol 'err'. > > # https://github.com/0day-ci/linux/commit/48b7a1af51abcb893917d986bc5ae5bae2d21ad6 > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout 48b7a1af51abcb893917d986bc5ae5bae2d21ad6 > vim +/type +194 fs/notify/fanotify/fanotify.c > Thanks for the report! > 1c529063 Eric Paris 2009-12-17 154 > 688d9244 Amir Goldstein 2019-01-10 155 static int fanotify_encode_fid(struct fanotify_event *event, > 48b7a1af Amir Goldstein 2019-01-10 156 const struct path *path, gfp_t gfp, > 48b7a1af Amir Goldstein 2019-01-10 157 __kernel_fsid_t *fsid) > 688d9244 Amir Goldstein 2019-01-10 158 { > 688d9244 Amir Goldstein 2019-01-10 159 struct fanotify_fid *fid = &event->fid; > 688d9244 Amir Goldstein 2019-01-10 160 int dwords, bytes = 0; > 688d9244 Amir Goldstein 2019-01-10 161 int err, type; > 688d9244 Amir Goldstein 2019-01-10 162 > 48b7a1af Amir Goldstein 2019-01-10 163 if (!fsid) > 48b7a1af Amir Goldstein 2019-01-10 164 goto out_err; Jan, Can you fix this up on commit to: int err = -ENODEV; int type = FILEID_INVALID; Thanks, Amir.
