On 1/10/19 4:26 PM, Vineet Gupta wrote: > It seems that 5f16f3225b0624 and 00a1a053ebe5, both with same commitlog > ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()") > introduced the set_mask_bits API, but somehow missed not using it in > ext4 in the end > > Also, set_mask_bits is used in fs quite a bit and we can possibly come up > with a generic llsc based implementation (w/o the cmpxchg loop) > > Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> > Cc: Theodore Ts'o <tytso@xxxxxxx> > Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx> > Cc: linux-fsdevel@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx> > Reviewed-by: Anthony Yznaga <anthony.yznaga@xxxxxxxxxx>