When epfd is polled by userspace and new item is inserted:
1. Get free bit for a new item.
2. If expand for user items or user index is required - route all events
to kernel lists and do expand.
3. If events are ready for newly inserted item - add event to uring,
if events have been just routed to klists - add item to rdllist.
4. On error path mark user item as freed and route events to klist
if ready event has not yet been observed by userspace. That is
needed to postpone bit put, otherwise newly allocated bit will
corrupt user item.
Signed-off-by: Roman Penyaev <rpenyaev@xxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Davidlohr Bueso <dbueso@xxxxxxx>
Cc: Jason Baron <jbaron@xxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Andrea Parri <andrea.parri@xxxxxxxxxxxxxxxxxxxx>
Cc: linux-fsdevel@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
---
fs/eventpoll.c | 74 ++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 65 insertions(+), 9 deletions(-)
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 36c451c26681..4618db9c077c 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1977,6 +1977,7 @@ static int ep_insert(struct eventpoll *ep, const struct epoll_event *event,
struct epitem *epi;
struct ep_pqueue epq;
+ lockdep_assert_held(&ep->mtx);
lockdep_assert_irqs_enabled();
user_watches = atomic_long_read(&ep->user->epoll_watches);
@@ -2002,6 +2003,43 @@ static int ep_insert(struct eventpoll *ep, const struct epoll_event *event,
RCU_INIT_POINTER(epi->ws, NULL);
}
+ if (ep_polled_by_user(ep)) {
+ struct user_epitem *uitem;
+ int bit;
+
+ bit = ep_get_bit(ep);
+ if (unlikely(bit < 0)) {
+ error = bit;
+ goto error_get_bit;
+ }
+ epi->bit = bit;
+ ep->items_nr++;
+
+ if (ep_expand_user_is_required(ep)) {
+ /*
+ * Expand of user header or user index is required,
+ * thus reroute all events to klists and then safely
+ * vrealloc() the memory.
+ */
+ write_lock_irq(&ep->lock);
+ ep_route_events_to_klists(ep);
+ write_unlock_irq(&ep->lock);
+
+ error = ep_expand_user_items(ep);
+ if (unlikely(error))
+ goto error_expand;
+
+ error = ep_expand_user_index(ep);
+ if (unlikely(error))
+ goto error_expand;
+ }
+
+ /* Now fill-in user item */
+ uitem = &ep->user_header->items[epi->bit];
+ uitem->ready_events = 0;
+ uitem->event = *event;
+ }
+
/* Initialize the poll table using the queue callback */
epq.epi = epi;
init_poll_funcptr(&epq.pt, ep_ptable_queue_proc);
@@ -2046,16 +2084,23 @@ static int ep_insert(struct eventpoll *ep, const struct epoll_event *event,
/* record NAPI ID of new item if present */
ep_set_busy_poll_napi_id(epi);
- /* If the file is already "ready" we drop it inside the ready list */
- if (revents && !ep_is_linked(epi)) {
- list_add_tail(&epi->rdllink, &ep->rdllist);
- ep_pm_stay_awake(epi);
+ if (revents) {
+ bool added = false;
- /* Notify waiting tasks that events are available */
- if (waitqueue_active(&ep->wq))
- wake_up(&ep->wq);
- if (waitqueue_active(&ep->poll_wait))
- pwake++;
+ if (ep_events_routed_to_uring(ep))
+ added = ep_add_event_to_uring(epi, revents);
+ else if (!ep_is_linked(epi)) {
+ list_add_tail(&epi->rdllink, &ep->rdllist);
+ ep_pm_stay_awake(epi);
+ added = true;
+ }
+ if (added) {
+ /* Notify waiting tasks that events are available */
+ if (waitqueue_active(&ep->wq))
+ wake_up(&ep->wq);
+ if (waitqueue_active(&ep->poll_wait))
+ pwake++;
+ }
}
write_unlock_irq(&ep->lock);
@@ -2089,6 +2134,17 @@ static int ep_insert(struct eventpoll *ep, const struct epoll_event *event,
list_del_init(&epi->rdllink);
write_unlock_irq(&ep->lock);
+ if (ep_polled_by_user(ep)) {
+error_expand:
+ /*
+ * No need to check return value: if events are routed to
+ * klists, that is done by code above, where we've expanded
+ * memory, but here, on rollback, we do not care.
+ */
+ (void)ep_free_user_item(epi);
+ }
+
+error_get_bit:
wakeup_source_unregister(ep_wakeup_source(epi));
error_create_wakeup_source:
--
2.19.1
