On Wed, Jan 02, 2019 at 07:54:26PM -0800, Andrei Vagin wrote:
[I'm thoroughly sick of refcounting in that thing, TBH ;-/]
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index a19f0fec9d82..fe67b5e81f9a 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -2019,7 +2019,7 @@ int cgroup_do_get_tree(struct fs_context *fc)
>
> ret = kernfs_get_tree(fc);
> if (ret < 0)
> - goto out_cgrp;
> + return ret;
Why does that case avoid needing cgroup_put()? Note, BTW, that we
also have this:
/*
* Destroy a cgroup filesystem context.
*/
static void cgroup_fs_context_free(struct fs_context *fc)
{
struct cgroup_fs_context *ctx = cgroup_fc2context(fc);
kfree(ctx->name);
kfree(ctx->release_agent);
if (ctx->root)
cgroup_put(&ctx->root->cgrp);
put_cgroup_ns(ctx->ns);
kernfs_free_fs_context(fc);
kfree(ctx);
}
which also needs to be taken into account.
