Re: [PATCH 09/22] aio: add submission side request cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +/*
> + * After the iocb has been issued, it's safe to be found on the poll list.
> + * Adding the kiocb to the list AFTER submission ensures that we don't
> + * find it from a io_getevents() thread before the issuer is done accessing
> + * the kiocb cookie.
> + */
> +static void aio_iopoll_iocb_issued(struct aio_submit_state *state,
> +				   struct aio_kiocb *kiocb)
> +{
> +	if (!state || !IS_ENABLED(CONFIG_BLOCK))
> +		aio_iopoll_iocb_add_list(kiocb);

This still looks odd to me.  Why would be make a batch or not batch
decision based on CONFIG_BLOCK availability?  Either batching is safe
for all ops, in which case we should always enabled it, or it only makes
sense for block devices / block backed filesystem in which case we need
a per-operation check.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux