On Fri, Dec 21, 2018 at 12:22:21PM -0700, Jens Axboe wrote: > This is just like io_setup(), except add a flags argument to let the > caller control/define some of the io_context behavior. > > Outside of the flags, we add two user pointers for future use. > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Hmm, I don't think think I was fine with the current version.. > +/* sys_io_setup2: > + * Like sys_io_setup(), except that it takes a set of flags > + * (IOCTX_FLAG_*), and some pointers to user structures: > + * > + * *user1 - reserved for future use > + * > + * *user2 - reserved for future use. > + */ > +SYSCALL_DEFINE5(io_setup2, u32, nr_events, u32, flags, void __user *, user1, > + void __user *, user2, aio_context_t __user *, ctxp) Most importantly I'm really worried about these new user1 and user2 fields, which aren't really used for aio poll. They are used for the I/O ring, which while I think is a really great concept, I am also worried about overlaying into the aio interface just creating confusion..
