On Tue, Dec 18, 2018 at 06:42:35PM +0800, Ian Kent wrote: > Sorry Al, that's my bad. > > See https://www.ozlabs.org/~akpm/mmotm/broken-out/autofs-fix-possible-inode-leak-in-autofs_fill_super.patch > > I think this will fix it, I'll forward it to Andrew if you agree: Just drop it and be done with that. d_make_root(NULL) returns NULL, no need to check that in the caller. There is no leak in the mainline; the calling conventions for d_make_root() are chosen that way just for that reason - to minimize the amount of cleanups needed.