On 12/15/18 4:51 AM, Christoph Hellwig wrote: > On Thu, Dec 13, 2018 at 04:25:27PM -0600, Eric Sandeen wrote: >> From: Eric Sandeen <sandeen@xxxxxxxxxx> >> >> because iomap_page_create initializes the uptodate bitmap using the macro, >> not the open-coded value. > > I find the use of SECTOR_SIZE rather confusing, especially as often > the sector size might actually be something else. It also forces > us to pull in another huge header file. Then we should hard code "512" in iomap_page_create I guess. Just need consistency. -Eric
