On 12/13/18 4:24 PM, Christoph Hellwig wrote:
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> --- fs/direct-io.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 41a0e97252ae..77adf33916b8 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -542,10 +542,13 @@ static blk_status_t dio_bio_complete(struct dio *dio, struct bio *bio) blk_status_t err = bio->bi_status; if (err) {I think this just need to become: if (err) dio->io_error = blk_status_to_errno(bio->bi_status); And Avi, you really should be using XFS ;-)
I did see this on XFS too. The whole thing bothers me, it doesn't happen consistently in some setups, which I don't understand. Either it should trigger always or never.
