Re: [PATCH] fix page_count in ->iomap_migrate_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Richard Weinberger <richard@xxxxxx>
Subject: Re: [PATCH] fix page_count in ->iomap_migrate_page()
From: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 15 Dec 2018 11:51:12 +0100
Cc: zhangjun <openzhangj@xxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, hch@xxxxxx, bfoster@xxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, mhocko@xxxxxxxx, n-horiguchi@xxxxxxxxxxxxx, mgorman@xxxxxxxxxxxxxxxxxxx, aarcange@xxxxxxxxxx, willy@xxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Gao Xiang <gaoxiang25@xxxxxxxxxx>
In-reply-to: <1618433.IpySj692Hd@blindfold>
User-agent: Mutt/1.5.17 (2007-11-01)

FYI, for iomap we got a patch to just increment the page count when
setting the private data, and it finally got merged into mainline after
a while.

Not that it totally makes sense to me, but it is what it is.  It would
just be nice if set_page_private took care of it and we had a
clear_page_private to undo it, making the whole scheme at lot more
obvious.

Follow-Ups:
- Re: [PATCH] fix page_count in ->iomap_migrate_page()
  - From: Richard Weinberger

References:
- [PATCH] fix page_count in ->iomap_migrate_page()
  - From: zhangjun
- Re: [PATCH] fix page_count in ->iomap_migrate_page()
  - From: Richard Weinberger

Prev by Date: Re: [PATCH 2/3 V2] mm: don't search past page end in is_partially_uptodate
Next by Date: Re: [PATCH 1/3] iomap: use SECTOR_SIZE instead of 512 in iomap_page
Previous by thread: Re: [PATCH] fix page_count in ->iomap_migrate_page()
Next by thread: Re: [PATCH] fix page_count in ->iomap_migrate_page()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]