On Mon, Mar 31, 2008 at 11:30:58AM -0700, Mingming Cao wrote: > On Mon, 2008-03-31 at 10:57 -0500, James Bottomley wrote: > > This commit: > > > > commit e898f3154d78d1520265aade0992981866d827fb > > Author: Duane Griffin <duaneg@xxxxxxxxx> > > Date: Tue Mar 25 19:47:39 2008 -0400 > > > > jbd2: tidy up revoke cache initialisation and destruction > > > > Introduced a thinko (it doesn't check whether jbd2_revoke_record cache > > is null, it checks jbd2_revoke_table_cache twice). > > > > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Mingming Cao <cmm@xxxxxxxxxx> > > Thanks, I picked this up in ext4 patch queue. anyone care to convert this function to proper goto-based error unwinding? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html