Re: [PATCH] fuse: continue to send FUSE_RELEASEDIR when FUSE_OPEN returns ENOSYS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/11/18, 11:26 AM, "Miklos Szeredi" <miklos@xxxxxxxxxx> wrote:

> On Mon, Dec 10, 2018 at 8:05 PM Chad Austin <chadaustin@xxxxxx> wrote:
>>
>> When FUSE_OPEN returns ENOSYS, the no_open bit is set on the
>> connection. Because the FUSE_RELEASE and FUSE_RELEASEDIR paths share
>> code, this incorrectly caused the FUSE_RELEASEDIR request to be
>> dropped and never sent to userspace. Pass an isdir bool to distinguish
>> between FUSE_RELEASE and FUSE_RELEASEDIR inside of fuse_file_put.
>>
>> Fixes: 7678ac50615d ("fuse: support clients that don't implement 'open'")

> Thanks.

> You did not add a Signed-off-by.   Can I add it for you?

By all means, thank you.

> opcode and isdir are redundant.  I've fixed it up (kept isdir) to
> match fuse_open_common() signature.

Perfect!

Chad






[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux