Re: [PATCH] fanotify: Use inode_is_open_for_write

[Jan Kara <jack@xxxxxxx>]

On Tue 11-12-18 10:27:23, Nikolay Borisov wrote:
> Use the aptly named function rather than opencoding i_writecount check.
> No functional changes.
> 
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>

Thanks! Added to my tree.

								Honza
> ---
>  fs/notify/fanotify/fanotify_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index e03be5071362..98b0769e4cf2 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -669,7 +669,7 @@ static int fanotify_add_inode_mark(struct fsnotify_group *group,
>  	 */
>  	if ((flags & FAN_MARK_IGNORED_MASK) &&
>  	    !(flags & FAN_MARK_IGNORED_SURV_MODIFY) &&
> -	    (atomic_read(&inode->i_writecount) > 0))
> +	    inode_is_open_for_write(inode))
>  		return 0;
>  
>  	return fanotify_add_mark(group, &inode->i_fsnotify_marks,
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR