On Tue, Dec 11, 2018 at 8:12 AM Matthew Bobrowski <mbobrowski@xxxxxxxxxxxxxx> wrote: > > On Mon, Dec 10, 2018 at 05:20:38PM +0100, Jan Kara wrote: > > On Sat 08-12-18 11:26:38, Amir Goldstein wrote: > > > On Sun, Dec 2, 2018 at 1:38 PM Amir Goldstein <amir73il@xxxxxxxxx> wrote: > > > > > > > > When setting up an fanotify listener, user may request to get fid > > > > information in event instead of an open file descriptor. > > > > > > > > The fid obtained with event on a watched object contains the file > > > > handle returned by name_to_handle_at(2) and fsid returned by statfs(2). > > > > > > > > When setting a mark, we need to make sure that the filesystem > > > > supports encoding file handles with name_to_handle_at(2) and that > > > > statfs(2) encodes a non-zero fsid. > > > > > > > > > > Jan, > > > > > > On a discussion with Matthew about tests he is writing for FAN_REPORT_TID, > > > the issue of permission events came up. > > > Since I am not aware of any specific benefit that FAN_REPORT_TID could > > > bring to users of permission events, I think the best course of action is to > > > limit the use of FAN_REPORT_TID to group with priority FAN_CLASS_NOTIF. > > > That would simplify tests and man page and if we ever see a use case for > > > anything else, we can add that in the future. > > > > > > If you agree, we should add something like this to this patch: > > > > Yeah, that's a good point. Agreed. > > OK, good to know. I will continue to write the FAN_REPORT_FID tests based on > Amir's fanotify_dirent branch, which contains the amendment suggested below. > > Amir, presumably we should also have a separate test that covers the expected > error result when FAN_REPORT_FID is supplied with invalid class bits? > Sure, that sounds good. I also did not find any test coverage for expected error result when trying to set permission mark bits on a FAN_CLASS_NOTIF group, so the same test could be the home of this test case as well. Going further to dirent events, we would also want to add validation that dirent event cannot be set on mark for group without FAN_REPORT_FID and cannot be set on a mount mark. Thanks, Amir.
