On Fri, Dec 07, 2018 at 04:52:42PM -0800, John Hubbard wrote:
> I see. OK, HMM has done an efficient job of mopping up unused fields, and now we are
> completely out of space. At this point, after thinking about it carefully, it seems clear
> that it's time for a single, new field:
Sorry for not replying earlier; I'm travelling and have had trouble
keeping on top of my mail.
Adding this field will grow struct page by 4-8 bytes, so it will no
longer be 64 bytes. This isn't an acceptable answer.
We have a few options for bits. One is that we have (iirc) two
bits available in page->flags on 32-bit. That'll force a few more
configurations into using _last_cpupid and/or page_ext. I'm not a huge
fan of this approach.
The second is to use page->lru.next bit 1. This requires some care
because m68k allows misaligned pointers. If the list_head that it's
joined to is misaligned, we'll be in trouble. This can get tricky because
some pages are attached to list_heads which are on the stack ... and I
don't think gcc guarantees __aligned attributes work for stack variables.
The third is to use page->lru.prev bit 0. We'd want to switch pgmap
and hmm_data around to make this work, and we'd want to record this
in mm_types.h so nobody tries to use a field which aliases with
page->lru.prev and has bit 0 set on a page which can be mapped to
userspace (which I currently believe to be true).
The fourth is to use a bit in page->flags for 64-bit and a bit in
page_ext->flags for 32-bit. Or we could get rid of page_ext and grow
struct page with a ->flags2 on 32-bit.
Fifth, it isn't clear to me how many bits might be left in ->_last_cpupid
at this point, and perhaps there's scope for using a bit in there.
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
> index 5ed8f6292a53..1c789e324da8 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -182,6 +182,9 @@ struct page {
> /* Usage count. *DO NOT USE DIRECTLY*. See page_ref.h */
> atomic_t _refcount;
>
> + /* DMA usage count. See get_user_pages*(), put_user_page*(). */
> + atomic_t _dma_pinned_count;
> +
> #ifdef CONFIG_MEMCG
> struct mem_cgroup *mem_cgroup;
> #endif
>
>
> ...because after all, the reason this is so difficult is that this fix has to work
> in pretty much every configuration. get_user_pages() use is widespread, it's a very
> general facility, and...it needs fixing. And we're out of space.
>
> I'm going to send out an updated RFC that shows the latest, and I think it's going
> to include the above.
>
> --
> thanks,
> John Hubbard
> NVIDIA
>
