I think these definitely all clean the code up. They might add a couple of lines, net, but they certainly make it easier to read. As you noted, they also make it much harder to screw up the locking, which is even better. Just looking at it from an aesthetic point of view, it looks good to have these helpers around. -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html