On Fri, Nov 30, 2018 at 11:20:47AM -0800, Darrick J. Wong wrote: > Therefore, teach splice_direct_to_actor to clamp its requests to the > amount of free space in the pipe and remove the simulated short read > from the iomap directio code. Seems like this should be two different commits? E.g. fix the splice code first, remove the hack from XFS next? (and yes, I know we already have a similar but slightly different suggestion from Amir, but I don't think explicit reverts buy us anything). Otherwise this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>