On Wed, Nov 28, 2018 at 4:43 PM Jan Kara <jack@xxxxxxx> wrote: > > On Wed 28-11-18 16:39:31, Amir Goldstein wrote: > > On Wed, Nov 28, 2018 at 2:59 PM Jan Kara <jack@xxxxxxx> wrote: > > > > +/* > > > > + * This is a list of all events that may get sent to a parent based on fs event > > > > > > ^^^ Line too long. > > > > Heh?? checkpatch did not complain. It's 79 chars. > > My bad, just the quoting in the reply pushed the line over 80 chars and I > didn't realize that. > > > > > > > > +#define ALL_FSNOTIFY_EVENTS (ALL_FSNOTIFY_DIRENT_EVENTS| \ > > > ^^^ space here > > > > > > > My patch did not change indentation AFAIK. > > The new definition added is with tab (ALL_FSNOTIFY_DIRENT_EVENTS) > > but some of the existing definitions, even ones moved around are with space(s). > > Do you want me to change that? > > This is not about indentation but space before '|' operator... > Ah. ok. fixed. Thanks, Amir.
