Re: [PATCH 16/20] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 16, 2018 at 04:58:53PM +0100, Christoph Hellwig wrote:
> > +	error = bmap(inode, (sector_t *)&block);
> 
> You can't cast and int * to a sector_t * without causing problems.
> You'll need a local variable of type sector_t that the value
> gets assigned to and read back from instead.

Ok, thanks for the information, I'll update it, but, could you detail a bit more
what kind of problem you are referring to? I'm curious to understand why and
which kind of problems it can cause.

> Also shouldn't this patch be earlier in the series?

I opted to move this patch to the end of the series, when most of the fiemap
rework is done, I can move it to the beginning of the series if it's better.

-- 
Carlos



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux