On 11/17/18 7:40 AM, Al Viro wrote:
> On Sat, Nov 17, 2018 at 07:37:44AM -0700, Jens Axboe wrote:
>> If the ioprio capability check fails, we return without putting
>> the file pointer.
>>
>> Fixes: d9a08a9e616b ("fs: Add aio iopriority support")
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>>
>> diff --git a/fs/aio.c b/fs/aio.c
>> index b36691268b6c..9075571e673f 100644
>> --- a/fs/aio.c
>> +++ b/fs/aio.c
>> @@ -1436,7 +1436,7 @@ static int aio_prep_rw(struct kiocb *req, struct iocb *iocb)
>> ret = ioprio_check_cap(iocb->aio_reqprio);
>> if (ret) {
>> pr_debug("aio ioprio check cap error: %d\n", ret);
>> - return ret;
>> + goto err;
>
> Better an explicit fput() here, IMO...
OK, v2 sent.
--
Jens Axboe
