Re: [PATCH 20/20] ext4: Get rid of ->bmap interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -	if (EXT4_JOURNAL(inode) &&
> -	    ext4_test_inode_state(inode, EXT4_STATE_JDATA)) {
> -		/*
> -		 * This is a REALLY heavyweight approach, but the use of
> -		 * bmap on dirty files is expected to be extremely rare:
> -		 * only if we run lilo or swapon on a freshly made file
> -		 * do we expect this to happen.
> -		 *
> -		 * (bmap requires CAP_SYS_RAWIO so this does not
> -		 * represent an unprivileged user DOS attack --- we'd be
> -		 * in trouble if mortal users could trigger this path at
> -		 * will.)
> -		 *
> -		 * NB. EXT4_STATE_JDATA is not set on files other than
> -		 * regular files.  If somebody wants to bmap a directory
> -		 * or symlink and gets confused because the buffer
> -		 * hasn't yet been flushed to disk, they deserve
> -		 * everything they get.
> -		 */

Does the ext4 fiemap code have this magic handling?  If not are
we sure we can kill it?



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux