On Tue, Oct 30, 2018 at 02:18:09PM +0100, Carlos Maiolino wrote: > iomap_fiemap() isn't directly called by ioctl_fiemap(), so it doesn't > needed to be changed when fiemap_ctx has been added, update it now. That sentence has some grammar issues. How about simply: "Update iomap_fiemap to take a struct fiemap_ctx". > - struct fiemap_extent_info *fieinfo = f_ctx->fc_data; > u64 start = f_ctx->fc_start; > u64 len = f_ctx->fc_len; > struct gfs2_inode *ip = GFS2_I(inode); > @@ -2019,7 +2018,7 @@ static int gfs2_fiemap(struct inode *inode, struct fiemap_ctx *f_ctx) > if (ret) > goto out; > > - ret = iomap_fiemap(inode, fieinfo, start, len, &gfs2_iomap_ops); > + ret = iomap_fiemap(inode, f_ctx, start, len, &gfs2_iomap_ops); I think we should get rid of the start and len argument as well.
