Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 16 Nov 2018 14:38:45 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Dave Chinner <dchinner@xxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, dm-devel@xxxxxxxxxx, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Shaohua Li <shli@xxxxxxxxxx>, linux-raid@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, David Sterba <dsterba@xxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, Gao Xiang <gaoxiang25@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, Coly Li <colyli@xxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, Boaz Harrosh <ooo@xxxxxxxxxxxxxxx>, Bob Peterson <rpeterso@xxxxxxxxxx>, cluster-devel@xxxxxxxxxx
In-reply-to: <20181115085306.9910-9-ming.lei@redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Nov 15, 2018 at 04:52:55PM +0800, Ming Lei wrote:
> BTRFS is the only user of this helper, so move this helper into
> BTRFS, and implement it via bio_for_each_segment_all(), since
> bio->bi_vcnt may not equal to number of pages after multipage bvec
> is enabled.

btrfs only uses the value to check if it is larger than 1.  No amount
of multipage bio merging should ever make bi_vcnt go from 0 to 1 or
vice versa.

Follow-Ups:
- Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
  - From: Ming Lei

References:
- [PATCH V10 00/19] block: support multi-page bvec
  - From: Ming Lei
- [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
  - From: Ming Lei

Prev by Date: Re: [PATCH V10 07/19] btrfs: use bvec_last_segment to get bio's last page
Next by Date: [PATCH v2] mm: don't break integrity writeback on ->writepage() error
Previous by thread: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Next by thread: Re: [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]