On Thu, Nov 15, 2018 at 02:17:35AM -0800, Christoph Hellwig wrote:
> > +long pipe_set_max_safe_size(struct pipe_inode_info *pipe)
> > +{
> > + pipe_set_size(pipe, pipe_max_size);
> > + return pipe->buffers * PAGE_SIZE;
> > +}
>
> This should probably return an unsigned value, given that we don't return
> errors. Then again the callers ignores the return value entirely.
> Wouldn't it be easier to just call pipe_set_size from splice.c after
> removing the static marker?
I didn't want to use pipe_max_size outside of the pipe code. it's
definitely simpler without a wrapper if using pipe_max_size directly
is acceptable.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
