Re: [PATCH] fsnotify/fdinfo: include fdinfo.h for inotify_show_fdinfo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 14-11-18 16:12:14, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> inotify_show_fdinfo() is defined in fs/notify/fdinfo.c and declared in
> fs/notify/fdinfo.h, but the declaration isn't included at the point of
> the definition.  Include the header to enforce that the definition
> matches the declaration.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Good point. Patch applied. Thanks!

								Honza

> ---
>  fs/notify/fdinfo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> index 348a184bcdda3..1e2bfd26b3521 100644
> --- a/fs/notify/fdinfo.c
> +++ b/fs/notify/fdinfo.c
> @@ -15,6 +15,7 @@
>  #include <linux/exportfs.h>
>  
>  #include "inotify/inotify.h"
> +#include "fdinfo.h"
>  #include "fsnotify.h"
>  
>  #if defined(CONFIG_PROC_FS)
> -- 
> 2.19.1.930.g4563a0d9d0-goog
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux