On Wed 14-11-18 10:54:46, Matthew Bobrowski wrote: > On Tue, Nov 13, 2018 at 07:53:07PM +0200, Amir Goldstein wrote: > > > > @@ -131,11 +137,7 @@ static bool fanotify_should_send_event(struct fsnotify_iter_info *iter_info, > > > > !(marks_mask & FS_ISDIR & ~marks_ignored_mask)) > > > > return false; > > > > > > Looking into this before merge, this hunk has apparently slipped during > > > some rebase (missing false->0 conversion). > > > > > > > - if (event_mask & FANOTIFY_OUTGOING_EVENTS & > > > > - marks_mask & ~marks_ignored_mask) > > > > - return true; > > > > - > > > > - return false; > > > > + return event_mask & FANOTIFY_OUTGOING_EVENTS & marks_mask; > > > > > > And here we miss & ~marks_ignored_mask, right? > > > > > > I've changed both in the patch I've merged but I'm checking just to be > > > sure... > > > > > FWIW, changes look correct to me. > > Yes, that would be right Jan. Thanks for confirmation. Patches pushed out. Thanks for your work and also to Amir for his review and comments! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
