Steven Whitehouse <swhiteho@xxxxxxxxxx> writes: > Hi, > > > On 31/10/18 15:38, Eric W. Biederman wrote: >> Al Viro <viro@xxxxxxxxxxxxxxxxxx> writes: >> >>> mount API series from David Howells. Last cycle's objections >>> had been of the "I'd do it differently" variety and with no such >>> differently done variants having ever materialized over several >>> cycles... >> Absolutely not. >> >> My objections fundamentally is that I can find real problems when I look >> at the code. Further the changes have not been incremental changes that >> have evolved the code from one state to another but complete >> replacements of code that make code review very difficult and bisection >> completely inapplicable. >> >> I also object that this series completely fails to fix the worst but I >> have ever seen in the mount API. Whit no real intrest shown in working >> to fix it. >> >> A couple of bugs that I can see quickly. Several of which I have >> previously reported: >> >> - There is an easily triggered NULL pointer deference with open_tree >> and mount propagation. >> >> > Can you share some details of what this NULL dereference is? David and > Al have been working on the changes as requested by Linus later in > this thread, and they'd like to tidy up this issue too at the same > time if possible. We are not asking you to actually provide a fix, in > case you are too busy to do so, however it would be good to know what > the issue is so that we can make sure that it is resolved in the next > round of patches, https://lore.kernel.org/lkml/87bm7n5k1r.fsf@xxxxxxxxxxxx/ Eric
